Re: [PATCH] ARM: dts: r9a06g032: Add #address-cells in the GIC node

From: Herve Codina

Date: Wed Mar 11 2026 - 06:26:35 EST


Hi Geert,

On Wed, 11 Mar 2026 09:39:40 +0100
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> Hi Wolfram,
>
> On Wed, 11 Mar 2026 at 09:32, Wolfram Sang
> <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, Mar 03, 2026 at 11:20:29AM +0100, Herve Codina (Schneider Electric) wrote:
> > > When checking dts involving the r9a06g032.dtsi file, the following kind
> > > of warnings are reported:
> > > Missing property '#address-cells' in node xxx, using 0 as fallback
> > >
> > > Indeed, #address-cells is not present in the GIC interrupt controller
> > > node.
> > >
> > > Fix it adding the missing property.
> > >
> > > No functional change.
> > >
> > > Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@xxxxxxxxxxx>
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> >
> > I like Krzysztof's explanation "Value '0' is correct because GIC
> > interrupt controller does not have children." Maybe it can be added to
> > the commit message?
>
> Some of the examples in the GIC DT bindings, do?
> But #address-cells is not a required property in the GIC DT bindings,
> so why should it be added at all?
>
> BTW, I never understood why an interrupt-controller should have
> #address-cells (according to dtc)?

I think this comes from the interrupt-map definition:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#interrupt-map

Best regards,
Hervé