Re: [PATCH 3/3] arm64: dts: qcom: kaanapali: Fix deprecated cpu compatibles
From: Krzysztof Kozlowski
Date: Wed Mar 11 2026 - 06:45:52 EST
On 11/03/2026 11:04, Krzysztof Kozlowski wrote:
> On Tue, Mar 10, 2026 at 09:37:51AM +0530, Sibi Sankar wrote:
>> The generic Qualcomm Oryon CPU compatible used by the Kaanapali
>> SoC is deprecated and incorrect since it uses a single compatible
>> to describe two different core variants. It is now replaced with
>> two different core-specific compatibles based on MIDR part and
>> variant number.
>>
>> CPUS 0-5:
>> MIDR_EL1[PART_NUM] - 0x2
>> MIDR_EL1[VARIANT] - 0x2
>>
>> CPUS 6-7:
>> MIDR_EL1[PART_NUM] - 0x2
>> MIDR_EL1[VARIANT] - 0x3
>>
>> Fixes: 2eeb5767d53f ("arm64: dts: qcom: Introduce Kaanapali SoC")
>> Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> I explained you in off-list communication what you have to do - this
> MUST go via fixes and you MUST annotate that.
>
> Where did you describe that? Nothing in cover letter, nothing here.
Although then binding should go via fixes but it depends on patch in
next branch, so it cannot be done. Sorry, this waited way tooooo long,
so you cannot make this change anymore.
Please drop it and you are stuck with the compatible you sent earlier,
which reviewers requested multiple times to change.
Best regards,
Krzysztof