Re: [PATCH 1/2] dt-bindings: gpio: cdns: add clock-names property

[Zichar Zhang]

On Sat, Mar 07, 2026 at 04:19:50PM +0100, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On Fri, Mar 06, 2026 at 05:32:37PM +0800, Zichar Zhang wrote:
> > From: "Zichar.Zhang" <zichar.zhang@xxxxxxxxxxx>
> >
> > Add the optional 'clock-names' property to specify the name of the GPIO
> > controller's input clock, aligning with standard clock binding conventions.
> 
> No, there are no such standard clock binding conventions. DT maintainer
> tells you that.
> 
> Otherwise explain me where did we document such convention?
> 
> > This complements the existing 'clocks' property and ensures proper clock
> > handling in device tree descriptions.
> >
> > Signed-off-by: Zichar Zhang <zichar.zhang@xxxxxxxxxxx>
> 
> Messed From/DCO.
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

Thanks, Done

> 
> > ---
> >  Documentation/devicetree/bindings/gpio/cdns,gpio.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> > index a84d60b39459..c242b31edcbf 100644
> > --- a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> > @@ -24,6 +24,12 @@ properties:
> >    clocks:
> >      maxItems: 1
> >
> > +  clock-names:
> > +    description:
> > +      Optional name for the GPIO controller input clock.
> > +    minItems: 1
> 
> Nope. From where did you take such syntax? Missing proper constraints
> for names.
> 
> I don't see reason for this in the first place and your commit msg is
> really poor in explaining WHY you are doing this.

Thanks, I will remove this patch