Re: [PATCH 1/2] iio: dac: ltc2632: add support for LTC2654 DAC family

[Andy Shevchenko]

On Tue, Mar 10, 2026 at 04:29:48PM +0100, David Marinović wrote:
> 
> Add support for the Linear Technology LTC2654 quad DAC family.
> The LTC2654 is a 4-channel, 16-/12-bit DAC with SPI interface,
> sharing the same 24-bit SPI protocol as the existing LTC2632/
> LTC2634/LTC2636 devices supported by this driver.
> 
> Add support for the following variants:
> - LTC2654L-16: 16-bit, 2.5V internal reference
> - LTC2654L-12: 12-bit, 2.5V internal reference
> - LTC2654H-16: 16-bit, 4.096V internal reference
> - LTC2654H-12: 12-bit, 4.096V internal reference

...

> enum ltc2632_supported_device_ids {

>         ID_LTC2636H12,
>         ID_LTC2636H10,
>         ID_LTC2636H8,
> +       ID_LTC2654L16,
> +       ID_LTC2654L12,
> +       ID_LTC2654H16,
> +       ID_LTC2654H12

You see how nicely the new IDs landed here, but after you it will require an
unneeded churn.

>  };

...

> static const struct spi_device_id ltc2632_id[] = {

>         { "ltc2636-h12",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636H12] },
>         { "ltc2636-h10",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636H10] },
>         { "ltc2636-h8", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636H8]
> },
> +       { "ltc2654-l16",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2654L16] },
> +       { "ltc2654-l12",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2654L12] },
> +       { "ltc2654-h16",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2654H16] },
> +       { "ltc2654-h12",
> (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2654H12] },
>         { }

Can we have a refactor patch to drop that enum and use separate chip_info
static objects?

>  };

...

> static const struct of_device_id ltc2632_of_match[] = {

>         }, {
>                 .compatible = "lltc,ltc2636-h8",
>                 .data = &ltc2632_chip_info_tbl[ID_LTC2636H8]
> +       }, {
> +               .compatible = "lltc,ltc2654-l16",
> +               .data = &ltc2632_chip_info_tbl[ID_LTC2654L16]
> +       }, {
> +               .compatible = "lltc,ltc2654-l12",
> +               .data = &ltc2632_chip_info_tbl[ID_LTC2654L12]
> +       }, {
> +               .compatible = "lltc,ltc2654-h16",
> +               .data = &ltc2632_chip_info_tbl[ID_LTC2654H16]
> +       }, {
> +               .compatible = "lltc,ltc2654-h12",
> +               .data = &ltc2632_chip_info_tbl[ID_LTC2654H12]
>         },

Ditto.

>         { }
>  };

...

> Subject: [PATCH 0/2] iio: dac: ltc2632: add support for LTC2654 DAC family
> Date: 10.03.2026 16:27
> From: David Marinović <david.marinovic@xxxxxxxx>
> To: jic23@xxxxxxxxxx
> 
> This patch series adds support for the Linear Technology LTC2654
> quad DAC family to the existing ltc2632 driver.

Huh?!

-- 
With Best Regards,
Andy Shevchenko