Re: [PATCH v5 2/3] arm64: dts: qcom: Introduce sa8255p SoC

[Bartosz Golaszewski]

On Thu, 5 Mar 2026 05:28:29 +0100, Deepti Jaggi
<deepti.jaggi@xxxxxxxxxxxxxxxx> said:
> From: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
>
> Introduce base device tree support for sa8255p Qualcomm's automotive
> infotainment SoC. The base dt file describes core SoC components- CPUs,
> CPU map, ipcc, QUP,  geni UART, interrupt controller, TLMM, reserved
> memory, SMMU, firmware scm, scmi, watchdog, SRAM, PSCI, ufs, pcie, pmu
> nodes and enable booting to shell with ramdisk.
>
> The Qualcomm automotive sa8255p SoC utilizes firmware to configure
> platform resources such as clocks, interconnects, and TLMM. Device drivers
> request these resources through the SCMI power,reset and performance
> protocols. Assign each device driver a dedicated SCMI channel and Tx/Rx
> doorbells to support parallel resource requests and aggregation in the
> SCMI platform server. Operate the SCMI server stack in an SMP-enabled VM,
> using the Qualcomm SMC/HVC transport driver for communication.
>
> Group resource operations to improve abstraction and reduce the number of
> SCMI requests. Follow the SCMI-based resource management approach
> demonstrated by Qualcomm at LinaroConnect 2024.[1]
>
> Limit initial support to basic platform resources, serial console, ufs
> and pcie.Defer enabling USB, and Ethernet to subsequent updates.
>
> [1]: https://resources.linaro.org/en/resource/wfnfEwBhRjLV1PEAJoDDte
>
> Co-developed-by: Shazad Hussain <shazad.hussain@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shazad Hussain <shazad.hussain@xxxxxxxxxxxxxxxx>
> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
> Co-developed-by: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
> Signed-off-by: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
> ---

Just some nits, looks good to me.

>  arch/arm64/boot/dts/qcom/sa8255p.dtsi | 4861 +++++++++++++++++++++++++++++++++
>  1 file changed, 4861 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8255p.dtsi b/arch/arm64/boot/dts/qcom/sa8255p.dtsi
> new file mode 100644
> index 000000000000..4f8529db70f6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sa8255p.dtsi
> @@ -0,0 +1,4861 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/mailbox/qcom-ipcc.h>
> +
> +/ {
> +	interrupt-parent = <&intc>;
> +
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	clocks {

Stray newline.

> +
> +		bi_tcxo_div2: bi-tcxo-div2-clk {
> +			compatible = "fixed-factor-clock";
> +			clocks = <&xo_board_clk>;
> +			clock-mult = <1>;
> +			clock-div = <2>;
> +			#clock-cells = <0>;
> +		};
> +
> +

[snip]

> +	firmware: firmware {

You never use this label.

[snip]

Stray newline? Same elsewhere.

With that:

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>