Re: [PATCH v2] dt-bindings: spmi: qcom,x1e80100-spmi-pmic-arb: Document Eliza compatible

[Abel Vesa]

On 26-03-11 14:43:27, Konrad Dybcio wrote:
> On 3/11/26 2:29 PM, Abel Vesa wrote:
> > The SPMI multi-master Arbiter found on Eliza is version 7.2.0, yet
> > driver-wise, still compatible with the one featured on Hamoa (X1E80100),
> > which is 7.0.1.
> > 
> > So document the Eliza compatible and allow Hamoa one as fallback.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Instead of reworking the whole oneOf for compatibles,
> >   add Eliza similar to sar2130p.
> > - Link to v1: https://patch.msgid.link/20260311-eliza-bindings-spmi-v1-1-1a20eec1179e@xxxxxxxxxxxxxxxx
> > ---
> >  .../devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml          | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> > index 08369fdd2161..4152469b3880 100644
> > --- a/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> > +++ b/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> > @@ -23,6 +23,9 @@ allOf:
> >  properties:
> >    compatible:
> >      oneOf:
> > +      - items:
> > +          - const: qcom,eliza-spmi-pmic-arb
> > +          - const: qcom,x1e80100-spmi-pmic-arb
> >        - items:
> >            - const: qcom,sar2130p-spmi-pmic-arb
> >            - const: qcom,x1e80100-spmi-pmic-arb
> 
> I think Krzysztof's comment was meant to suggest you shouldn't add an
> intermittent items: entry for a single const (lone-x1e compatible), instead
> passing:
> 
> oneOf:
>  - items:
>    - enum:
>      - foo
>      - bar
>    - const: x1e
>     ...
>  - const: x1e

Oh, my bad then. You mean like this?

@@ -24,10 +24,9 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: qcom,eliza-spmi-pmic-arb
-          - const: qcom,x1e80100-spmi-pmic-arb
-      - items:
-          - const: qcom,sar2130p-spmi-pmic-arb
+          - enum:
+              - qcom,eliza-spmi-pmic-arb
+              - qcom,sar2130p-spmi-pmic-arb
           - const: qcom,x1e80100-spmi-pmic-arb
       - const: qcom,x1e80100-spmi-pmic-arb