Re: [PATCH v3 1/3] usb: typec: ucsi: Detect and skip duplicate altmodes from buggy firmware

From: Heikki Krogerus

Date: Wed Mar 11 2026 - 09:59:53 EST


Thu, Mar 05, 2026 at 04:58:02PM +0200, Dmitry Baryshkov kirjoitti:
> On Wed, Feb 11, 2026 at 06:37:41AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 11, 2026 at 11:32:37AM +0800, AceLan Kao wrote:
> > > A gentle ping.
> > > Please help to review these patches, thanks.
> >
> > Wait, no, we rejected this series and said "fix the firmware".
> >
> > What happened to doing that?
>
> Having a similar problem with other platforms. It's not always possible
> to fix the firmware. I have one platform with a similar issue, but that
> laptop is EOLed long ago (Lenovo Yoga C630, the issue has been worked
> around in the EC driver, but I'd be really happy to switch to the
> generic fixup). At this point it really feels that there might
> be more UCSI implemetations having this issue.

I would still like to get an answer from Dell for this (if this was
the Dell case). It looks like they are using the GET_ALTMODES_COMMAND
in some custom way. It's almost like they are first returning all the
SVIDs without the modes, followed by something else.

So even if these products are EOL, and we will never get the firmware
fixed, we still need to understand what exactly is being returned to
the command, and is it returned like that intentionally or not.

Br,

--
heikki