Re: [PATCH 1/2] dt-bindings: usb: nxp,ptn5110: add optional orientation-gpio property

[Xu Yang]

On Wed, Mar 11, 2026 at 01:59:10PM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 10, 2026 at 04:13:56PM +0800, Xu Yang wrote:
> > The Type-C chip know the cable orientation and then normally will set the
> > switch channel to correctly configure the data path. Some chips itself
> > support to output the control signal by indicating the capability in
> > bit[0] of STANDARD_OUTPUT_CAPABILITIES register and do it in
> > CONFIG_STANDARD_OUTPUT register. For other chips which don't present this
> > capability currently there are no way to achieve the orientation setting.
> > Add an optional "orientation-gpio" property to achieve the same purpose.
> > 
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> > index 65a8632b4d9e..866b5d033f4e 100644
> > --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> > +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> > @@ -26,6 +26,11 @@ properties:
> >      $ref: /schemas/connector/usb-connector.yaml#
> >      unevaluatedProperties: false
> >  
> > +  orientation-gpio:
> > +    description: Optional orientation select control if the chip doesn't
> > +      present "Connector Orientation" bit[0] in STANDARD_OUTPUT_CAPABILITIES
> 
> What do you mean by "if the chip"? There is only one chip, so its
> registers are fixed. Why would this device sometimes report it and
> sometimes not?

Yes, you are right. PTN5110 is the only TCPCI compatible chip in this
binding, so its registers are fixed. I forgot this truth and thought it's
for all TCPCI compatible chip. I will remove the confused words.

Thanks,
Xu Yang