Re: [PATCH v9 3/3] x86/cpu: Do a sanity check on required feature bits

From: Maciej Wieczor-Retman

Date: Wed Mar 11 2026 - 11:49:03 EST


On 2026-03-11 at 14:33:29 +0000, Maciej Wieczor-Retman wrote:
>On 2026-03-10 at 16:13:25 -0700, Sohil Mehta wrote:
>>On 3/10/2026 11:03 AM, Maciej Wieczor-Retman wrote:
>>> +/*
>>> + * As a sanity check compare the final x86_capability bitmask with the initial
>>> + * predefined required feature bits. In case of a mismatch emit a warning with
>>> + * all the missing feature names or X86_FEATURE_* numerals.
>>> + */
>>
>>I feel the second sentence is more appropriate as part of the commit
>>message instead of a code comment.
>
>Okay, yeah, I can move it there.

On second thought, looking at it more, it's probably quite visible from the diff
what's gonna happen on mismatch. Perhaps it's better if I just remove this line
from the comment.

--
Kind regards
Maciej Wieczór-Retman