Re: [PATCH] ASoC: soc-topology: fix __le32 conversion in printed values

[Mark Brown]

On Wed, Mar 11, 2026 at 05:17:29PM +0000, Ben Dooks wrote:
> On 11/03/2026 17:11, Mark Brown wrote:
> > On Tue, Mar 10, 2026 at 09:49:48AM +0000, Ben Dooks wrote:

> > >   {
> > >   	dev_err(tplg->dev,
> > >   		"ASoC: no complete control IO handler for %s type (g,p,i) %d:%d:%d at 0x%lx\n",
> > > -		name, hdr->ops.get, hdr->ops.put, hdr->ops.info,
> > > +		name,
> > > +		le32_to_cpu(hdr->ops.get),
> > > +		le32_to_cpu(hdr->ops.put),
> > > +		le32_to_cpu(hdr->ops.info),

> > Shouldn't we also change the prints to %u given that le32_to_cpu() works
> > with unsigned data (IIRC)?

> Possibly. But given the data was already marked __le32 it was already
> unsigned.

> Do we want to go through changing these before committing this or
> delay it to another patch?

If we're going around shutting up warnings it seems better to do
everything properly.

Attachment: signature.asc
Description: PGP signature