Re: [PATCH] irqchip/riscv-aplic: fix PM for multi-aplic system
From: Thomas Gleixner
Date: Wed Mar 11 2026 - 14:21:34 EST
On Wed, Mar 11 2026 at 16:37, Vladimir Kondratiev wrote:
> This results in double registration of the same syscore. Warning
> triggered:
>
> [ 0.553569] ------------[ cut here ]------------
> [ 0.553572] list_add double add: new=ffffffff81314a68, prev=ffffffff81314a68, next=ffffffff8131f588.
>
> Move syscore registration to the driver init
This is completely wrong because it installs the syscore ops
unconditionally even when there is no APLIC available in the
system. Works for me is not the right approach.
> Fixes: 95a8ddde3660 ("irqchip/riscv-aplic: Preserve APLIC states across suspend/resume")
No. It makes it worse.
> Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx>
But nothing to do here anymore. This got already fixed correctly:
https://lore.kernel.org/all/20260310141349432DBRJJclgnBHYWu8it0geX@xxxxxxxxxx/
Thanks
tglx