[PATCH 2/7] drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure
From: Krzysztof Kozlowski
Date: Wed Mar 11 2026 - 16:18:48 EST
msm_hdmi_get_phy() already prints error messages on each error path
using dev_err_probe(), so final DRM_DEV_ERROR() would duplicate it and
possibly flood the dmesg on probe deferrals.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index b1db1b597901..02a87bccab77 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -358,10 +358,8 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev)
gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD");
ret = msm_hdmi_get_phy(hdmi);
- if (ret) {
- DRM_DEV_ERROR(&pdev->dev, "failed to get phy\n");
+ if (ret)
return ret;
- }
ret = devm_pm_runtime_enable(&pdev->dev);
if (ret)
--
2.51.0