Re: [PATCH v3 1/7] pinctrl: introduce pinctrl_gpio_get_config()

[Andy Shevchenko]

On Wed, Mar 11, 2026 at 10:38:07PM +0300, Dan Carpenter wrote:

> This is a counterpart of pinctrl_gpio_set_config(), which will be used
> to implement the ->get() interface in a GPIO driver for SCMI.

...

> +/**
> + * pinctrl_gpio_get_config() - Get the config for a given GPIO pin
> + * @gc: GPIO chip structure from the GPIO subsystem
> + * @offset: hardware offset of the GPIO relative to the controller
> + * @config: the configuration to query.  On success it holds the result

kernel-doc is not happy: return section is missing.
Always run it with -Wall to see that.

> + */

...

I'm also wondering if this needs to be used in / already part of UP board pin
control and GPIO driver. There they used a proxy based on gpio-aggregator code.
With this it might be (I haven't checked at all) that the code can be simplified.

-- 
With Best Regards,
Andy Shevchenko