Re: [PATCH 3/5] selftests/cgroup: use runtime page size for zswpin check

[Li Wang]

On Wed, Mar 11, 2026 at 11:56:38AM -0700, Yosry Ahmed wrote:
> On Wed, Mar 11, 2026 at 4:05 AM Li Wang <liwang@xxxxxxxxxx> wrote:
> >
> > test_zswapin compares memory.stat:zswpin (counted in pages) against a
> > byte threshold converted with PAGE_SIZE. In cgroup selftests, PAGE_SIZE
> > is hardcoded to 4096, which makes the conversion wrong on systems with
> > non-4K base pages (e.g. 64K).
> 
> This should be fixed in cgroup_util.h, but I see how that will be
> annoying as it's used to initialize a bunch of arrays. Looking a bit
> closer it seems like for most of these code paths it's really just a
> buffer size, not necessarily the system page size, so maybe we should
> just rename it?

Agree, maybe rename it to BUF_SIZE in anthoer seperate patch.

> For this patch, we actually need the system page size at runtime so
> this looks good:
> 
> Reviewed-by: Yosry Ahmed <yosry@xxxxxxxxxx>

Thanks!

-- 
Regards,
Li Wang