Re: [PATCH] staging: greybus: uart: add comments to locks and fix alignment

From: Greg KH

Date: Thu Mar 12 2026 - 01:12:12 EST


On Thu, Mar 12, 2026 at 12:11:04AM +0530, Rahul Joshi wrote:
> The spinlock_t and struct mutex members in struct gb_tty lack
> comments describing what they protect, which is required by the
> kernel coding style.
>
> Also fix the alignment of the wait_for_completion_timeout() call
> in gb_uart_wait_for_all_credits() to match the open parenthesis.

Each patch can only do 1 thing, when you say "Also" that's a huge hint
that something should be split up.

But, in this case, all of these changes have been rejected previously,
see the mailing list archives for details.

thanks,

greg k-h