Re: [PATCH RFC 2/2] usb: typec: qcom: Add support for shared USBIN VBUS detection

[Alexander Koskovich]

On Wednesday, March 11th, 2026 at 7:06 PM, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote:

> On 08/03/2026 23:20, Alexander Koskovich wrote:
> > +	if (IS_ERR(pmic_typec_port->vbus_detect_gpio))
> > +		return dev_err_probe(dev, PTR_ERR(pmic_typec_port->vbus_detect_gpio),
> > +				     "failed to get vbus-detect GPIO\n");
> > +
> 
> I'd prefer if this was bracketed since it is over more than one line.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Uploaded v2 but didn't carry your Reviewed-By since there's a fair bit of diff, can you look at v2 and check if all looks good?

> 
> ---
> bod
> 
> 

Thanks,
Alex