Re: [PATCHv2] gpio: ljca: reduce struct allocation

From: Linus Walleij

Date: Thu Mar 12 2026 - 04:18:18 EST


On Thu, Mar 12, 2026 at 12:19 AM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> On Wed, Mar 11, 2026 at 5:57 AM Linus Walleij <linusw@xxxxxxxxxx> wrote:
> > On Tue, Mar 10, 2026 at 11:21 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> >
> > > + size_t num;
> >
> > What about naming it num_connect_modes?
> > (and unsigned in as Sakari says.)
>
> Too long IMO. Makes the most sense to match variable names.

This is one of those times I would bring up Rusty Russell's
API item #6 "The name tells you how to use it." well,
does it? Number of what?

Yours,
Linus Walleij