RE: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Sherry Sun]

> Subject: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated
> reset-gpios
> 
> GPIOs with "gpio" suffix were long time ago deprecated, thus "reset-gpios" should
> be used.  Linux kernel supports both, referenced schema snps,dw-pcie-
> common.yaml lists both as well and this schema uses
> unevaluatedProperties:false, thus change has no impact except code readability
> and removing deprecated patterns.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 12a01f7a5744..b9ba938c6239 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -58,11 +58,6 @@ properties:
>        - const: msi
>        - const: dma
> 
> -  reset-gpio:
> -    description: Should specify the GPIO for controlling the PCI bus device
> -      reset signal. It's not polarity aware and defaults to active-low reset
> -      sequence (L=reset state, H=operation state) (optional required).
> -

Add Dmitry and Bartosz.

Hi Krzysztof,
Seems this property is still handled in gpiolib-of.c, see commit b8b80348c57b
("gpiolib: of: add polarity quirk for Freescale PCIe controller").
Maybe need to change the quirk gpio_propname here too.


>    reset-gpio-active-high:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,

 Also change the "reset-gpio" to "reset-gpios" in this description.

Best Regards
Sherry
> --
> 2.51.0
>