Re: [PATCH net-next V2 3/5] net/mlx5e: Report TX csum netdev stats

From: Gal Pressman

Date: Thu Mar 12 2026 - 05:50:40 EST


On 11/03/2026 5:18, Jakub Kicinski wrote:
> On Mon, 9 Mar 2026 11:55:17 +0200 Tariq Toukan wrote:
>> Report TX checksum statistics via the netdev queue stats API by mapping
>> the existing csum_none and csum_partial counters to the csum_none and
>> needs_csum fields.
>
> -
> name: tx-needs-csum
> doc: |
> Number of packets that required the device to calculate the checksum.
> This counter includes the number of GSO wire packets for which device
> calculated the L4 checksum.
> type: uint

Yea, we count GSO packets as one, so not a direct fit.

>
> Looking at drivers currently implementing this it seems like the idea
> was to avoid having to increment two counters in the drivers, given
> that TSO always implies csum offload

I don't think I understand what you're trying to say here.