Re: [PATCH 3/3] arm64: dts: qcom: eliza: Enable Eliza MTP board support

[Abel Vesa]

On 26-02-24 14:09:39, Konrad Dybcio wrote:
> On 2/24/26 1:13 PM, Abel Vesa wrote:
> > The Mobile Test Platform (MTP) is a reference development board
> > based on the Eliza SoC. So add dedicated board dts for it.
> > 
> > The initial support enables:
> > - UART debug console
> > - Ob-board UFS storage
> > - Qualcomm RPMh regulators (PMIC) and VPH_PWR
> > - board specific clocks & reserved GPIO ranges
> > 
> > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> 
> [...]
> 
> I didn't cross-check the regulator settings, but I hope you don't like
> this kind of fried chips!

Will double check.

> 
> 
> > +&qupv3_2 {
> > +	status = "okay";
> > +};
> 
> These are normally mass-AC-allowed for a given platform, feel free to
> enable by default

Sure, but then this will make this SoC the one-off, AFAICT.

> 
> > +
> > +&tlmm {
> > +	/* reserved for secure world */
> > +	gpio-reserved-ranges = <20 4>, <111 2>, <118 1>;
> 
> Would you know what they connect to? Please describe (like in x1-crd.dtsi)

Yep. Will describe.

> 
> > +};
> > +
> > +&uart14 {
> > +	compatible = "qcom,geni-debug-uart";
> > +	status = "okay";
> 
> Please keep a \n before status for consistency

Will do.

Thanks for reviewing.