Re: [PATCH] usb: serial: add RW135R-GL (33f8:1003) support

[Johan Hovold]

On Thu, Mar 12, 2026 at 07:32:14PM +0800, zwq2226404116@xxxxxxx wrote:
> From: Wanquan Zhong <wanquan.zhong@xxxxxxxxxxx>
> 
> Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
> used in laptop debug cards with MBIM interface for Linux/Chrome OS.
> The device supports mbim, diag, adb and AT commands.
> 
> Device info from lsusb:
> Bus 03 Device 12: ID 33f8:1003 Rolling Wireless S.a.r.l.

Please include the output from usb-devices which includes details about
the interfaces (see commit ae420771551b ("USB: serial: option: add
Rolling RW350-GL variants") for an example).

> Signed-off-by: Wanquan Zhong <wanquan.zhong@xxxxxxxxxxx>
> ---
>  drivers/usb/serial/option.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e349ed66d2ac..abeeb7c66977 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(4) | RSVD(5) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff),			/* Rolling RW135-GL (laptop MBIM) */
>  	  .driver_info = RSVD(5) },
> +	/* Rolling RW135R-GL (laptop MBIM) */

The comment should go after the entry (it's fine to ignore checkpatch
warnings about long lines here).

> +	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),

And please try to keep the entries sorted by VID/PID (i.e. put the new
one after Rolling RW350-GL).

> +	  .driver_info = RSVD(5) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) },			/* Rolling RW101-GL (laptop MBIM) */
>  	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) },			/* Rolling RW101-GL (laptop MBIM) */
>  	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff),			/* Rolling RW101-GL (laptop MBIM) */

Johan