Re: [PATCH net-next] dt-bindings: net: micrel: Fix dtbs compatible too long warnings

[Geert Uytterhoeven]

Hi Biju,

On Wed, 4 Feb 2026 at 10:18, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > From: Rob Herring <robh@xxxxxxxxxx>
> > On Tue, Feb 3, 2026 at 6:17 AM Biju <biju.das.au@xxxxxxxxx> wrote:
> > > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > The KSZ9131 PHY is suitable for IEEE 802.3 applications.
> > >
> > > Fix the below dtbs warning "compatible: ['ethernet-phy-id0022.1640',
> > > 'ethernet-phy-ieee802.3-c22'] is too long" on the below dts:
> > >
> > > r8a774b1-beacon-rzg2n-kit.dtb
> > > r8a774a1-beacon-rzg2m-kit.dtb
> > > r8a774e1-beacon-rzg2h-kit.dtb
> > > r9a08g046l48-smarc.dtb
> > > r9a07g043u11-smarc.dtb
> > > r9a07g044c2-smarc.dtb
> > > r9a07g044l2-smarc.dtb
> > > r9a07g044l2-smarc.dtb
> > > r9a07g054l2-smarc.dtb
> > > r9a07g054l2-smarc.dtb
> > > r9a09g047e57-smarc.dtb
> > > r9a09g047e57-smarc.dtb
> > > r9a09g056n48-rzv2n-evk.dtb
> > > r9a09g056n48-rzv2n-evk.dtb
> > > r9a09g057h44-rzv2h-evk.dtb
> > > r9a09g057h44-rzv2h-evk.dtb
> > > r9a07g043u11-smarc-cru-csi-ov5645.dtb
> > > r9a07g043u11-smarc-pmod.dtb
> > > r9a07g043u11-smarc-du-adv7513.dtb
> > > r9a09g047e57-smarc-cru-csi-ov5645.dtb
> > > r9a07g044c2-smarc-cru-csi-ov5645.dtb
> > > r9a09g047e57-smarc-cru-csi-ov5645.dtb
> > > r9a07g044l2-smarc-cru-csi-ov5645.dtb
> > > r9a07g044l2-smarc-cru-csi-ov5645.dtb
> > > r9a07g054l2-smarc-cru-csi-ov5645.dtb
> > > r9a07g054l2-smarc-cru-csi-ov5645.dtb
> > > r9a09g056n48-rzv2n-evk-cn15-emmc.dtb
> > > r9a09g056n48-rzv2n-evk-cn15-emmc.dtb
> > > r9a09g056n48-rzv2n-evk-cn15-sd.dtb
> > > r9a09g057h44-rzv2h-evk-cn15-sd.dtb
> > > r9a09g056n48-rzv2n-evk-cn15-sd.dtb
> > > r9a09g057h44-rzv2h-evk-cn15-emmc.dtb
> > > r9a09g057h44-rzv2h-evk-cn15-sd.dtb
> > > r9a09g057h44-rzv2h-evk-cn15-emmc.dtb
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > ---
> > >  .../bindings/net/micrel,gigabit.yaml          | 23 +++++++++++--------
> > >  1 file changed, 14 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/micrel,gigabit.yaml
> > > b/Documentation/devicetree/bindings/net/micrel,gigabit.yaml
> > > index 384b4ea6181e..284c3ba379f3 100644
> > > --- a/Documentation/devicetree/bindings/net/micrel,gigabit.yaml
> > > +++ b/Documentation/devicetree/bindings/net/micrel,gigabit.yaml
> > > @@ -17,15 +17,20 @@ description:
> > >
> > >  properties:
> > >    compatible:
> > > -    enum:
> > > -      - ethernet-phy-id0022.1610  # KSZ9021
> > > -      - ethernet-phy-id0022.1611  # KSZ9021RLRN
> > > -      - ethernet-phy-id0022.1620  # KSZ9031
> > > -      - ethernet-phy-id0022.1631  # KSZ9477
> > > -      - ethernet-phy-id0022.1640  # KSZ9131
> > > -      - ethernet-phy-id0022.1650  # LAN8841
> > > -      - ethernet-phy-id0022.1660  # LAN8814
> > > -      - ethernet-phy-id0022.1670  # LAN8804
> > > +    oneOf:
> > > +      - items:
> > > +          - const: ethernet-phy-id0022.1640
> > > +          - const: ethernet-phy-ieee802.3-c22
> >
> > To avoid the errors, you would need a custom 'select' that excludes the c22 compatible from this
> > schema (IOW, lists all the other compatibles here).
>
> OK.
>
> >
> > However, I think the correct fix is probably dropping the c22 compatible from your .dts files. I don't
> > that compatible is useful on its own?
>
> I will wait for Geert's input to drop c22 from .dts files.

Makes sense.

So we should probably fix the following, too?
Documentation/devicetree/bindings/net/ethernet-phy.yaml
Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
Documentation/devicetree/bindings/net/renesas,ether.yaml
Documentation/devicetree/bindings/net/renesas,etheravb.yaml
Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml

> > Also, it doesn't make sense that ethernet-phy-id0022.1640 is sometimes compatible with ethernet-phy-
> > ieee802.3-c22 and sometimes isn't.
>
> OK.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds