Re: [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg

From: Dan Carpenter

Date: Thu Mar 12 2026 - 10:03:19 EST


On Thu, Mar 12, 2026 at 07:18:07PM +0800, Zile Xiong wrote:
> Replace the empty modifier argument with a simple identity macro.
> This fixes the error reported by scripts/checkpatch.pl while keeping
> the original semantics unchanged.
>
> The generated code is equivalent and builds successfully.
>
> Signed-off-by: Zile Xiong <xiongzile99@xxxxxxxxx>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4..380dd374a566 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -61,10 +61,10 @@ out: \
> va_end(args); \
> } \
> EXPORT_SYMBOL(func);
> -
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +#define fbtft_identity(x) (x)

Someone sent this exact same patch before. Same name and everything.

https://lore.kernel.org/all/aYECoy7Apjwgzr9r@stanley.mountain/

A better sollution is to learn to just ignore checkpatch when it is
wrong. My previous email was longer.

regards,
dan carpenter