Re: [PATCH] regulator: pf1550: Remove redundant regmap assignment
From: Frank Li
Date: Thu Mar 12 2026 - 11:48:19 EST
On Thu, Mar 12, 2026 at 10:30:31PM +0800, Felix Gu wrote:
> The config.regmap is already correctly initialized using dev_get_regmap()
> on the parent device. Remove the redundant second assignment that was
> overwriting it with pf1550->regmap.
>
> Fixes: 7320d41c29bb ("regulator: pf1550: Add support for regulator")
Nit: This is not bug fix and it is code cleanup. Needn't fixes tag here
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
> drivers/regulator/pf1550-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/pf1550-regulator.c b/drivers/regulator/pf1550-regulator.c
> index 037b8ec94066..1d1726528460 100644
> --- a/drivers/regulator/pf1550-regulator.c
> +++ b/drivers/regulator/pf1550-regulator.c
> @@ -360,7 +360,6 @@ static int pf1550_regulator_probe(struct platform_device *pdev)
> "failed to get parent regmap\n");
>
> config.dev = pf1550->dev;
> - config.regmap = pf1550->regmap;
> info->dev = &pdev->dev;
> info->pf1550 = pf1550;
>
>
> ---
> base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
> change-id: 20260312-1550-327017c6f56c
>
> Best regards,
> --
> Felix Gu <ustc.gu@xxxxxxxxx>
>