Re: [PATCH v2] kasan: update outdated comment

[Andrey Ryabinin]

Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx> writes:

> The function kmalloc_large() was renamed kmalloc_large_noprof() by
> commit 7bd230a26648 ("mm/slab: enable slab allocation tagging for
> kmalloc and friends"), and subsequently renamed __kmalloc_large_noprof()
> by commit a0a44d9175b3 ("mm, slab: don't wrap internal functions with
> alloc_hooks()"), making it an internal implementation detail.
>
> Large kmalloc allocations are now performed through the public kmalloc()
> interface directly, making the reference to KMALLOC_MAX_SIZE also stale
> (KMALLOC_MAX_CACHE_SIZE would be more accurate). Remove the references
> to kmalloc_large() and KMALLOC_MAX_SIZE, and rephrase the description
> for large kmalloc allocations.
>
> Suggested-by: Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx>
> ---
>  include/linux/kasan.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx>


> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 338a1921a50a..bf233bde68c7 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -352,8 +352,8 @@ bool __kasan_mempool_poison_object(void *ptr, unsigned long ip);
>   * kasan_mempool_unpoison_object().
>   *
>   * This function operates on all slab allocations including large kmalloc
> - * allocations (the ones returned by kmalloc_large() or by kmalloc() with the
> - * size > KMALLOC_MAX_SIZE).
> + * allocations (i.e. the ones backed directly by the buddy allocator rather
> + * than kmalloc slab caches).
>   *
>   * Return: true if the allocation can be safely reused; false otherwise.
>   */
> @@ -381,8 +381,8 @@ void __kasan_mempool_unpoison_object(void *ptr, size_t size, unsigned long ip);
>   * original tags based on the pointer value.
>   *
>   * This function operates on all slab allocations including large kmalloc
> - * allocations (the ones returned by kmalloc_large() or by kmalloc() with the
> - * size > KMALLOC_MAX_SIZE).
> + * allocations (i.e. the ones backed directly by the buddy allocator rather
> + * than kmalloc slab caches).
>   */
>  static __always_inline void kasan_mempool_unpoison_object(void *ptr,
>  							  size_t size)
> --
> 2.25.1