Re: [PATCH v4 10/24] x86/virt/seamldr: Allocate and populate a module update request

From: Edgecombe, Rick P

Date: Thu Mar 12 2026 - 13:01:59 EST


On Thu, 2026-03-12 at 22:36 +0800, Chao Gao wrote:
> > > + if (blob->version != 0x100) {
> > Do we need a macro for this 0x100?
>
> Maybe not, as this is a one-off check (i.e., the version/macro won't be used
> anywhere else). If someone has a strong opinion on this, I can add one.

Seems like kind of a magic number as it is. What would the macro name be, and
would it make the code more understandable?