Re: [PATCH] regulator: fp9931: Fix error handling for optional regulator

[Mark Brown]

On Thu, Mar 12, 2026 at 06:58:54PM +0100, Andreas Kemnade wrote:
> Robby Cai <robby.cai@xxxxxxx> wrote:

> >  	data->vin_reg = devm_regulator_get_optional(&client->dev, "vin");

> looking at that thing again. I think I have abused the optional api.
> Of course this chip needs a supply. It may be hardwired so something
> not switchable. But that needs to be wired to something... So I think
> rather the _optional is wrong here.

If it's a mandatory supply that's right, I may have misunderstood what
the supply was doing when I originally reviewed this.

Attachment: signature.asc
Description: PGP signature