Re: [PATCH v3 01/11] mm: Relocate the page table ceiling and floor definitions
From: David Hildenbrand (Arm)
Date: Thu Mar 12 2026 - 15:54:49 EST
On 3/12/26 20:53, David Hildenbrand (Arm) wrote:
> On 1/21/26 17:49, Liam R. Howlett wrote:
>> pgtables.h defines a fallback for ceiling and floor of the page tables
>> within the CONFIG_MMU section. Moving the definitions to outside the
>> CONFIG_MMU Allows for using them in generic code.
>>
>> Suggested-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
>> Suggested-by: SeongJae Park <sj@xxxxxxxxxx>
>> Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
>> ---
>
>
> [...]
>
>> +
>> /*
>> * No-op macros that just return the current protection value. Defined here
>> * because these macros can be used even if CONFIG_MMU is not defined.
>> diff --git a/mm/vma_internal.h b/mm/vma_internal.h
>> index 2f05735ff190c..2da6d224c1a85 100644
>> --- a/mm/vma_internal.h
>> +++ b/mm/vma_internal.h
>> @@ -46,6 +46,7 @@
>> #include <linux/swap.h>
>> #include <linux/uprobes.h>
>> #include <linux/userfaultfd_k.h>
>> +#include <linux/pgtable.h>
>>
>> #include <asm/current.h>
>> #include <asm/tlb.h>
>
> I was also confused by that change. But it's not worth a respin :)
>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
>
Ah, and now realizing that this already hit upstream.
--
Cheers,
David