Re: [PATCH v2 8/9] Documentation/amd-pstate: List prefcore related sysfs files

[Mario Limonciello]

On 3/11/2026 9:01 AM, Gautham R. Shenoy wrote:
> Add the missing amd_pstate_hw_prefcore and amd_pstate_prefcore_ranking
> filenames in the sysfs listing example leading to the descriptions of
> these parameters.
>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>

Can you please split this into two patches?
In the first track down and add a Fixes tag for your next spin for the 
missing files.

In the second make the change about the visibility.

You can add to both:

Reviewed-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>

> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index e1771f2225d5f..f566fea6613e6 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -239,8 +239,10 @@ control its functionality at the system level. They are located in the
>   
>    root@hr-test1:/home/ray# ls /sys/devices/system/cpu/cpufreq/policy0/*amd*
>    /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_highest_perf
> + /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_hw_prefcore
>    /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_lowest_nonlinear_freq
>    /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_max_freq
> + /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_prefcore_ranking
>   
>   
>   ``amd_pstate_highest_perf / amd_pstate_max_freq``
> @@ -264,14 +266,17 @@ This attribute is read-only.
>   
>   ``amd_pstate_hw_prefcore``
>   
> -Whether the platform supports the preferred core feature and it has been
> -enabled. This attribute is read-only.
> +Whether the platform supports the preferred core feature and it has
> +been enabled. This attribute is read-only. This file is only visible
> +on platforms which support the preferred core feature.
>   
>   ``amd_pstate_prefcore_ranking``
>   
> -The performance ranking of the core. This number doesn't have any unit, but
> -larger numbers are preferred at the time of reading. This can change at
> -runtime based on platform conditions. This attribute is read-only.
> +The performance ranking of the core. This number doesn't have any
> +unit, but larger numbers are preferred at the time of reading. This
> +can change at runtime based on platform conditions. This attribute is
> +read-only.  This file is only visible on platforms which support the
> +preferred core feature.
>   
>   ``energy_performance_available_preferences``
>