Re: [PATCH] watchdog: mtx-1_wdt: synchronize timer teardown in remove

[Guenter Roeck]

On 3/12/26 14:06, aviv.daum@xxxxxxxxx wrote:
> From: avivdaum <aviv.daum@xxxxxxxxx>
>
> Replace the ad-hoc completion based teardown path with a proper
> timer synchronization call in remove.
>
> Stop the watchdog and delete the timer synchronously using
> timer_delete_sync(), then deregister the misc device.
>
> This removes the open FIXME about locking/testing of queue teardown
> and makes the driver follow the current timer API pattern used in
> watchdog drivers.
>
> Compile-tested: ARCH=mips CROSS_COMPILE=mips-linux-gnu-
>    32r2el_defconfig (drivers/watchdog/mtx-1_wdt.o, W=1/W=2)
> Compile-tested: ARCH=mips CROSS_COMPILE=mips-linux-gnu-
>    mtx1_defconfig (drivers/watchdog/mtx-1_wdt.o, W=1/W=2)
> Compile-tested: ARCH=mips CROSS_COMPILE=mips-linux-gnu-
>    malta_defconfig + WATCHDOG=y + COMPILE_TEST=y + WDT_MTX1=m
>    (drivers/watchdog/mtx-1_wdt.o, W=1/W=2)
> Signed-off-by: avivdaum <aviv.daum@xxxxxxxxx>

NACK, sorry. If you want to do anything with this driver, consider converting
it to use the watchdog subsystem (which would take care care of the timer
functionality).

Guenter