Re: [PATCH v2 1/4] mm/page_table_check: Pass mm_struct to pxx_user_accessible_page()

From: Vasily Gorbik

Date: Thu Mar 12 2026 - 18:47:18 EST


On Thu, Mar 12, 2026 at 01:57:57PM -0700, Andrew Morton wrote:
> On Thu, 12 Mar 2026 16:02:40 +0100 Vasily Gorbik <gor@xxxxxxxxxxxxx> wrote:
>
> > On Fri, Mar 06, 2026 at 05:16:30PM +0100, Alexander Gordeev wrote:
> > > From: Tobias Huschle <huschle@xxxxxxxxxxxxx>
> > >
> > > Unlike other architectures, s390 does not have means to
> > > distinguish kernel vs user page table entries - neither
> > > an entry itself, nor the address could be used for that.
> > > It is only the mm_struct that indicates whether an entry
> > > in question is mapped to a user space. So pass mm_struct
> > > to pxx_user_accessible_page() callbacks.
> > >
...
> > > ---
> > > arch/arm64/include/asm/pgtable.h | 6 +++---
> > > arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +-
> > > arch/powerpc/include/asm/book3s/64/pgtable.h | 10 +++++-----
> > > arch/powerpc/include/asm/nohash/pgtable.h | 2 +-
> > > arch/powerpc/include/asm/pgtable.h | 4 ++--
> > > arch/riscv/include/asm/pgtable.h | 6 +++---
> > > arch/x86/include/asm/pgtable.h | 6 +++---
> > > mm/page_table_check.c | 15 ++++++---------
> > > 8 files changed, 24 insertions(+), 27 deletions(-)
> >
> > Andrew, may I get your Reviewed-by or Ack-by for v2 so I can take it
> > via the s390 tree as well?
>
> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> It doesn't look like [1/4] changed significanty since v1?

PowerPC page table check support landed at the same
time v1 was sent, so v1 was missing PowerPC header
changes, which was reported by the kernel test robot:
https://lore.kernel.org/all/202603050830.LXQcUa5Z-lkp@xxxxxxxxx/
Hence, v2 to address that.