Re: [PATCH 0/4] selftests/mm: skip several tests when thp is not available

[Chunyu Hu]

On Thu, Mar 12, 2026 at 04:03:59PM +0200, Mike Rapoport wrote:
> On Thu, Mar 12, 2026 at 07:40:23PM +0800, Chunyu Hu wrote:
> > There are several tests requires transprarent hugepages, when run on thp
> > disabled kernel such as realtime kernel, there will be false positve.
> 
> I presume that when THP tests run on kernels with THP disabled they fail
> and it would be a false negative rather than false positive.


This is an interesting point. I'm not naitive speaker. I just learned
from AI. It really matters what we define as 'postive'. I presume 'postive'
is we run selftest and got a failure report, that's postive, not thinking
as it's thp disabled kernel and a 'pass' is postive.

I'll add statement about 'postive' in v2 like "a test failure is
defiend as postive"

> 
> > Mark those tests as skip when thp is not available.
> > 
> > Chunye Hu (4):
> >   selftests/mm/guard-regions: skip collapse test when thp not enabled
> >   selftests/mm: soft-dirty: skip two tests when thp not available
> >   selftests/mm: split_huge_page_test: skip the test when thp not
> >     available
> >   selftests/mm: transhuge_stress: skip the test when thp not available
> > 
> >  tools/testing/selftests/mm/guard-regions.c        | 4 ++++
> >  tools/testing/selftests/mm/soft-dirty.c           | 4 +++-
> >  tools/testing/selftests/mm/split_huge_page_test.c | 9 +++++++--
> >  tools/testing/selftests/mm/transhuge-stress.c     | 4 ++++
> >  4 files changed, 18 insertions(+), 3 deletions(-)
> > 
> > 
> > base-commit: 80234b5ab240f52fa45d201e899e207b9265ef91
> > -- 
> > 2.53.0
> > 
> 
> -- 
> Sincerely yours,
> Mike.
>