RE: [PATCH v5 2/5] dt-bindings: PCI: imx6q-pcie: Add i.MX94 and i.MX943 PCIe compatible strings

[Hongxing Zhu]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2026年3月12日 21:32
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; Frank Li
> <frank.li@xxxxxxx>; l.stach@xxxxxxxxxxxxxx; lpieralisi@xxxxxxxxxx;
> kwilczynski@xxxxxxxxxx; mani@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 2/5] dt-bindings: PCI: imx6q-pcie: Add i.MX94 and
> i.MX943 PCIe compatible strings
> 
> On Thu, Mar 12, 2026 at 05:27:42PM +0800, Richard Zhu wrote:
> > Add i.MX94 and i.MX943 PCIe compatible strings and fallback to
> > i.MX95 PCIe compatible string.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > ---
> >  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       |  6 ++++
> >  .../bindings/pci/fsl,imx6q-pcie.yaml          | 28 ++++++++++++-------
> >  2 files changed, 24 insertions(+), 10 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > index 0b3526de1d62..323ed3105d33 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > @@ -24,6 +24,8 @@ properties:
> >        - fsl,imx8mp-pcie-ep
> >        - fsl,imx8q-pcie-ep
> >        - fsl,imx95-pcie-ep
> > +      - fsl,imx94-pcie-ep
> > +      - fsl,imx943-pcie-ep
> 
> How is it that the RC is compatible with imx95, but the EP is not? It's the same
> h/w.
> 
Hi Rb:
Thanks for your comments.
I discovered that my schema_check script wasn't validating *-ep.yaml 
endpoint binding files. Would change them later.

Best Regards
Richard Zhu
> >
> >    clocks:
> >      minItems: 3
> > @@ -94,6 +96,8 @@ allOf:
> >          compatible:
> >            enum:
> >              - fsl,imx95-pcie-ep
> > +            - fsl,imx94-pcie-ep
> > +            - fsl,imx943-pcie-ep
> >      then:
> >        properties:
> >          reg:
> > @@ -114,6 +118,8 @@ allOf:
> >            enum:
> >              - fsl,imx8mq-pcie-ep
> >              - fsl,imx95-pcie-ep
> > +            - fsl,imx94-pcie-ep
> > +            - fsl,imx943-pcie-ep
> >      then:
> >        properties:
> >          clocks:
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 7fe1e0e9b565..46c1fabcd070 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -21,16 +21,24 @@ description: |+
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - fsl,imx6q-pcie
> > -      - fsl,imx6sx-pcie
> > -      - fsl,imx6qp-pcie
> > -      - fsl,imx7d-pcie
> > -      - fsl,imx8mq-pcie
> > -      - fsl,imx8mm-pcie
> > -      - fsl,imx8mp-pcie
> > -      - fsl,imx95-pcie
> > -      - fsl,imx8q-pcie
> > +    oneOf:
> > +      - enum:
> > +          - fsl,imx6q-pcie
> > +          - fsl,imx6sx-pcie
> > +          - fsl,imx6qp-pcie
> > +          - fsl,imx7d-pcie
> > +          - fsl,imx8mq-pcie
> > +          - fsl,imx8mm-pcie
> > +          - fsl,imx8mp-pcie
> > +          - fsl,imx95-pcie
> > +          - fsl,imx8q-pcie
> > +          - fsl,imx94-pcie
> > +          - fsl,imx943-pcie
> > +      - items:
> > +          - enum:
> > +            - fsl,imx94-pcie
> > +            - fsl,imx943-pcie
> > +          - const: fsl,imx95-pcie
> >
> >    clocks:
> >      minItems: 3
> > --
> > 2.37.1
> >