Re: [PATCH 3/3] arm64: dts: qcom: Add Mahua SoC and CRD

[Manaf Meethalavalappu Pallikunhi]

Hi Dmitry,


On 3/12/2026 8:32 AM, Dmitry Baryshkov wrote:
> On Mon, Mar 09, 2026 at 10:49:47PM -0700, Gopikrishna Garmidi wrote:
> > Introduce support for the Mahua SoC and the CRD based on it. Some of
> > the notable differences are the absent CPU cluster, interconnect, TLMM,
> > thermal zones and adjusted PCIe west clocks. Everything else should
> > work as-is.
> >
> > Co-developed-by: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile            |    1 +
> >   arch/arm64/boot/dts/qcom/glymur.dtsi         |    2 +-
> >   arch/arm64/boot/dts/qcom/mahua-crd.dts       |   21 +
> >   arch/arm64/boot/dts/qcom/mahua.dtsi          | 1040 ++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/pmcx0102.dtsi       |    2 +-
> >   arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi |    4 +-
> >   6 files changed, 1066 insertions(+), 4 deletions(-)
> >   create mode 100644 arch/arm64/boot/dts/qcom/mahua-crd.dts
> >   create mode 100644 arch/arm64/boot/dts/qcom/mahua.dtsi
> >
> > +
> > +&tsens4 {
> > +	#qcom,sensors = <13>;
>
> This matches the value in glymur.dtsi

my bad, it is supposed to be 11 for mahua. It is taken care in below 
thermal zone list. Will update in next revision.
> > +};
> > +
> > +&tsens5 {
> > +	#qcom,sensors = <15>;
>
> This one is indeed different.
>
> > +};
> > +
> > +/ {
> > +	thermal_zones: thermal-zones {
>
> You've completely rewritten thermal zones. Can we patch them instead?
> The difference would be more obvious this way.

Out of the 69 sensors in Mahua, around 27 sensors show discrepancies 
when compared with Glymur. These differences are not limited to sensor 
ID updates alone; due to changes in sensor mapping, some nodes trip and 
cooling binding require node-level updates.
Additionally, approximately 23 thermal zone sensor nodes need to be 
deleted individually, since Glymur has a total of 92 sensors.
Considering this, would it be better to delete the entire set of thermal 
zones and reconfigure them specifically for Mahua to improve clarity and 
maintainability? I noticed that Purwa followed a similar approach.

Thanks,
Manaf

>