Re: [PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9

[Krzysztof Kozlowski]

On Thu, Mar 12, 2026 at 01:55:08PM +0200, Yedaya Katsman wrote:
> Document Samsung S6E8FCO DTS binding used with the M1906F9 6.09" 720x1560
> panel found in the Xiaomi Mi A3 smartphone.
> 
> Co-developed-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> Signed-off-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> Signed-off-by: Yedaya Katsman <yedaya.ka@xxxxxxxxx>
> ---
>  .../display/panel/samsung,s6e8fco-m1906f9.yaml     | 63 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++
>  2 files changed, 68 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..927d170793dcd49c19ebe353268980710ad4b5b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,s6e8fco-m1906f9.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S6E8FCO DSI for the Samsung M1906F9 AMOLED Panel
> +
> +maintainers:
> +  - Yedaya Katsman <yedaya.ka@xxxxxxxxx>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,s6e8fco-m1906f9
> +
> +  reg:
> +    maxItems: 1
> +
> +  vddi-supply:
> +    description: VDDI regulator
> +  vci-supply:
> +    description: VCI regulator

I pointed out last time to other schemas and after changes you should
notice that it is the same as other bindings. Or almost the same. See:
samsung,s6e88a0-ams452ef01
samsung,s6e88a0-ams427ap24
samsung,s6e8aa5x01-ams561ra01

so should be added there - to the last one - instead of having one more
file. On mentioned schematics I did not see the panel, thus the pin
supply does not need to be named VDDI, just because output of the PMIC
is called like that.

Best regards,
Krzysztof