Re: [PATCH] wifi: mac80211: fix WARN_ON_ONCE in ieee80211_tdls_oper

From: Deepanshu Kartikey

Date: Fri Mar 13 2026 - 05:32:03 EST


On Fri, Mar 13, 2026 at 12:42 PM Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:

> On Tue, 2026-03-10 at 21:30 +0530, Deepanshu Kartikey wrote:
> I think that check needs to be earlier, otherwise side effects happen
> (TDLS_PEER_AUTH flag).
>
> Also, I'm a bit confused, how is it possible the sta_info_get() worked,
> but there's no TDLS? Maybe really what it needs is
>
> sta = sta_info_get(sdata, peer);
> - if (!sta)
> + if (!sta || !sta->sta.tdls)
> return -ENOLINK;
>
> instead?
>
> johannes

Thanks for the clarification. I have sent the v2 patch.

Deepanshu