Re: [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks

From: Konrad Dybcio

Date: Fri Mar 13 2026 - 06:25:33 EST


On 3/12/26 2:29 PM, Dmitry Baryshkov wrote:
> Unlike other drivers, the DPU driver checks for exact UBWC version,
> making it hard to add minor versions if necessary. Invert the order of
> UBWC checks, letting the DPU driver handle new minors transparently.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

[...]

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad

> } else {
> DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_version);

note this is existing behavior, but do we want to write to these
registers on platforms without UBWC, instead of returning early?

Konrad