Re: [PATCH v2] ACPI, x86/boot: Remove {set|get}_root_pointer() ACPI callbacks

[Hou Wenlong]

On Fri, Mar 13, 2026 at 01:28:08PM +0100, Borislav Petkov wrote:
> On Fri, Mar 06, 2026 at 11:25:30AM +0800, Hou Wenlong wrote:
> > After removing pvh_get_root_pointer(), the only get_root_pointer() ACPI
> > callback is x86_default_get_root_pointer(). So call it directly in
> > acpi_arch_get_root_pointer() and remove the get_root_pointer() ACPI
> > callback. Since the set_root_pointer() ACPI callback is also only
> > x86_default_set_root_pointer(), remove it as well.
> > 
> > Note that x86_default_get_root_pointer() cannot be directly folded into
> > acpi_arch_get_root_pointer() for now, as it references 'boot_params',
> > which requires including asm/bootparams.h. This header file, in turn,
> > includes linux/screen_info.h, which declares pixel_format as a struct,
> > while amdgpu defines it as an enum, leading to namespace clashes.
> 
> How about disambiguating them and fixing this properly?
>

Okay, I’ll give it a try. 

Based on my grep search, I found three definitions of 'pixel_format' in the
entire codebase:
- include/video/pixel_format.h
- drivers/gpu/drm/i915/gvt/fb_decoder.c
- drivers/gpu/drm/amd/display/dc/dc_hw_types.h

My understanding is that the 'include' directory has higher priority
than drivers directory, so the first one should be kept. I would need to
modify the other two definitions by adding module-specific prefixes to
them?

Thanks!

>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette