Re: [PATCH v2] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen

[Abel Vesa]

On 26-03-13 13:57:56, Konrad Dybcio wrote:
> On 3/12/26 2:00 PM, Abel Vesa wrote:
> > On CRD, the keyboard, trackpad and touchscreen are connected over I2C
> > and all share a 3.3V regulator.
> > 
> > So describe the regulator and each input device along with their
> > pinctrl states.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> 
> > +
> > +	ts0_default: ts0-default-state {
> > +		int-n-pins {
> > +			pins = "gpio51";
> > +			function = "gpio";
> > +			bias-disable;
> > +		};
> > +
> > +		reset-n-pins {
> > +			pins = "gpio48";
> > +			function = "gpio";
> > +			output-high;
> 
> we shouldn't need to drive this pin by default (also missing bias setting)

Good catch.

Will fix.

> 
> other than that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Thanks.