Re: [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support

[Bartosz Golaszewski]

On Thu, Mar 12, 2026 at 9:43 AM Junhui Liu <junhui.liu@xxxxxxxxxxxxx> wrote:
>
> Assign gpiochip_generic_config() to the set_config() callback to support
> pin configuration through the GPIO subsystem. This allows users to
> configure GPIO pin attributes like pull-up/down when specifying a GPIO
> line in the Device Tree.
>
> Signed-off-by: Junhui Liu <junhui.liu@xxxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-spacemit-k1.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
> index dbd2e81094b9..5fe813b7f9bb 100644
> --- a/drivers/gpio/gpio-spacemit-k1.c
> +++ b/drivers/gpio/gpio-spacemit-k1.c
> @@ -228,6 +228,7 @@ static int spacemit_gpio_add_bank(struct spacemit_gpio *sg,
>         gc->label               = dev_name(dev);
>         gc->request             = gpiochip_generic_request;
>         gc->free                = gpiochip_generic_free;
> +       gc->set_config          = gpiochip_generic_config;
>         gc->ngpio               = SPACEMIT_NR_GPIOS_PER_BANK;
>         gc->base                = -1;
>         gc->of_gpio_n_cells     = 3;
>
> --
> 2.53.0
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>

Linus, please take it through the pinctrl tree.

Bart