Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices

[Dmitry Baryshkov]

On Fri, Mar 13, 2026 at 03:59:52PM +0530, Anvesh Jain P wrote:
> From: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> 
> Add Embedded controller driver support for Hamoa/Purwa/Glymur qualcomm
> reference boards. It handles fan control, temperature sensors, access
> to EC state changes and supports reporting suspend entry/exit to the
> EC.
> 
> Co-developed-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> Co-developed-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
> Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
> ---
>  MAINTAINERS                            |   8 +
>  drivers/platform/arm64/Kconfig         |  12 +
>  drivers/platform/arm64/Makefile        |   1 +
>  drivers/platform/arm64/qcom-hamoa-ec.c | 468 +++++++++++++++++++++++++++++++++
>  4 files changed, 489 insertions(+)
> 
> --- /dev/null
> +++ b/drivers/platform/arm64/qcom-hamoa-ec.c
> @@ -0,0 +1,468 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2024 Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> + * Copyright (c) 2026, Qualcomm Technologies, Inc. and/or its subsidiaries.

Drop the year from Qualcomm copyright, please.

> + */
> +
> +#include <linux/bitfield.h>
> +#include <linux/i2c.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/pm.h>
> +#include <linux/thermal.h>

Please add <linux/slab.h> and <linux/interrupt.h>

With that and with the typo fixed,


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



-- 
With best wishes
Dmitry