Re: [PATCH 2/3] gpio: timberdale: use device properties

[Andy Shevchenko]

On Fri, Mar 13, 2026 at 02:27:36PM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 13, 2026 at 11:21 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Fri, Mar 13, 2026 at 11:04:49AM +0100, Bartosz Golaszewski wrote:

...

> > > +     err = device_property_read_u32(dev, "intel,gpio-base", &gc->base);
> >
> > In drivers/mfd/intel_quark_i2c_gpio.c we use 'gpio-base' and I prefer to have
> > it common since it's Linux only property for now. Alternatively patch that to
> > have a snps prefix.
> 
> So "gpio-base" and "snps,irq-base" for the properties?

Either 'gpio-base' in all drivers that use it only as Linux property
(currently 2 + potentially this one), OR fixing _there_ (in two drivers)
by having 'snps,gpio-base' _there_, not in this driver.

And if you choose the former (dropping the vendor prefix here), the 'irq-base'
with it (vendor prefix) will look inconsistent.

> > > +     if (err)
> > > +             return err;

-- 
With Best Regards,
Andy Shevchenko