Re: [PATCH 2/2] gpu: nova-core: add fwctl driver for firmware control interface

[Jason Gunthorpe]

On Fri, Mar 13, 2026 at 05:03:28PM +0100, Danilo Krummrich wrote:
> >  /**
> > diff --git a/include/uapi/fwctl/nova-core.h b/include/uapi/fwctl/nova-core.h
> > new file mode 100644
> > index 000000000000..3f1d94b44ec8
> > --- /dev/null
> > +++ b/include/uapi/fwctl/nova-core.h
> 
> Why is this not include/uapi/gpu/nova-core.h? This driver does not live under
> drivers/fwctl/.

I would prefer if it did, but understand if it doesn't want to for
reasons.

But the uapi headers still must live in uapi/fwctl/ not someplace
else, that is important.

Jason