[PATCH v3] staging: media: atomisp: use kmalloc_array() for sh_css_blob_info
From: Lin YuChen
Date: Fri Mar 13 2026 - 13:59:24 EST
Replace the open-coded multiplication in kmalloc() with kmalloc_array()
to provide overflow protection and improve code readability.
Signed-off-by: Lin YuChen <starpt.official@xxxxxxxxx>
---
v3:
- Resend as a single patch to fix the incorrect versioning and
numbering (1/2, 2/2) in the previous submission.
v2:
- Remove unnecessary parentheses in kmalloc_array() call as suggested
by Andy Shevchenko.
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index 57ecf5549c23..af12df2f9b09 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -253,9 +253,9 @@ sh_css_load_firmware(struct device *dev, const char *fw_data,
sh_css_num_binaries = file_header->binary_nr;
/* Only allocate memory for ISP blob info */
if (sh_css_num_binaries > NUM_OF_SPS) {
- sh_css_blob_info = kmalloc(
- (sh_css_num_binaries - NUM_OF_SPS) *
- sizeof(*sh_css_blob_info), GFP_KERNEL);
+ sh_css_blob_info =
+ kmalloc_array(sh_css_num_binaries - NUM_OF_SPS,
+ sizeof(*sh_css_blob_info), GFP_KERNEL);
if (!sh_css_blob_info)
return -ENOMEM;
} else {
--
2.34.1