Re: [PATCH v2 1/2] net: stmmac: fix pinctrl management during suspend/resume

[Linus Walleij]

On Fri, Mar 13, 2026 at 12:08 PM Russell King (Oracle)
<linux@xxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 13, 2026 at 11:57:16AM +0100, Christophe Roullier wrote:
> > In the deepest low-power modes, the pinctrl configuration is lost
> > and is never restored if the interface is down.
> > This commit ensures that the pinctrl state is set in all cases.
>
> Shouldn't the pin state be restored by the pinctrl layer?

What we have in the device core only applies "init" and "default"
states, and provides these handles for transitioning to "sleep"
and "default" again (like a state machine).

I would love to handle this in the PM core, but devices are a
bit sensitive to where this is applied wrt e.g. some register
writes that need to happen before/after this pin transition etc
so it's called explicitly like this from each drivers suspend()
and resume() hooks.

So FWIW:
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij