Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio
From: Rob Herring (Arm)
Date: Fri Mar 13 2026 - 20:39:10 EST
On Thu, 12 Mar 2026 19:43:45 +0100, Krzysztof Kozlowski wrote:
> The binding references snps,dw-pcie-common.yaml which already deprecates
> "reset-gpio", however mentioning this property here lacks this mark thus
> code is confusing and suggests property is not deprecated.
>
> OTOH, the property cannot be removed from this schema, because it is an
> ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible
> map between compatibles, "reset-gpio" and "reset-gpio-active-high"
> properties.
>
> This creates code and binding which is not obvious to follow, so rewrite
> it and be more explicit about:
> 1. Deprecation of "reset-gpio",
> 2. Relation that "reset-gpio-active-high" is used only for that property
> and not proper "reset-gpios".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> ---
>
> Cc: Sherry Sun <sherry.sun@xxxxxxx>
>
> Changes in v2:
> 1. Rewrite the commit completely after Sherry Sun comments - keep the
> property, but add "not" clause to forbid usavge of
> "reset-gpio-active-high" and "reset-gpios".
> 2. Because of above not adding Richard's ack.
>
> v1:
> https://lore.kernel.org/r/20260311154955.145120-3-krzysztof.kozlowski@xxxxxxxxxxxxxxxx
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>