Re: [PATCH v7 2/2] drm/bridge: Add ITE IT61620 MIPI DSI to HDMI bridge driver

[Dmitry Baryshkov]

On Fri, Mar 13, 2026 at 02:48:16PM +0800, Pet Weng wrote:
> This adds support for the ITE IT61620 bridge chip which converts
> MIPI DSI input to HDMI output. The Driver implements the basic
> bridge functions and integrates with the DRM bridge and connector
> frameworks.
> 
> Supported features include:
> MIPI DSI input handling
> HDMI output setup
> Basic mode configuration
> I2C-based control and initialization
> HDCP 1.4 handling
> 
> HPD handling clarification:
> Although IT61620 has an HPD pin, hotplug detection is handled by the
> system connector. The bridge only receives HPD notifications, and the
> HPD pin is used solely for short pulses during HDCP authentication.
> Therefore, this bridge does not implement OP_HPD or OP_DETECT, as it
> does not originate or determine hotplug or connection status.
> 
> This driver will be used on platforms embedding the IT61620 for
> video output via HDMI from SoCs with MIPI DSI output.
> 
> Add a MAINTAINERS entry for the IT61620 bridge driver.
> 
> Signed-off-by: Pet Weng <pet.weng@xxxxxxxxxx>
> ---
>  MAINTAINERS                          |    7 +
>  drivers/gpu/drm/bridge/Kconfig       |   18 +
>  drivers/gpu/drm/bridge/Makefile      |    1 +
>  drivers/gpu/drm/bridge/ite-it61620.c | 2590 ++++++++++++++++++++++++++++++++++
>  4 files changed, 2616 insertions(+)
> 
> +
> +static void it61620_bridge_hdmi_audio_shutdown(struct drm_bridge *bridge,
> +					       struct drm_connector *connector)
> +{
> +	struct it61620 *it61620 = bridge_to_it61620(bridge);

Here should be a call to
drm_atomic_helper_connector_hdmi_clear_audio_infoframe().
It can be fixed while applying.

> +
> +	it61620_disable_audio(it61620);
> +}
> +

Other than that, LGTM.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



-- 
With best wishes
Dmitry