Re: [PATCH v1 1/8] dt-bindings: mfd: Add bindings for TI TAC5x1x MFD core

[Krzysztof Kozlowski]

On 12/03/2026 19:48, Niranjan H Y wrote:
> Add device tree bindings for the Texas Instruments TAC5x1x family of
> audio codecs with integrated GPIO controller, describing the MFD core
> device interface, power supplies, and clock configuration.
> 
> Signed-off-by: Niranjan H Y <niranjan.hy@xxxxxx>
> ---
>  .../devicetree/bindings/mfd/ti,tac5x1x.yaml   | 247 ++++++++++++++++++
>  1 file changed, 247 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,tac5x1x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,tac5x1x.yaml b/Documentation/devicetree/bindings/mfd/ti,tac5x1x.yaml
> new file mode 100644
> index 000000000000..3d7943c0411f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,tac5x1x.yaml
> @@ -0,0 +1,247 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,tac5x1x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAC5x1x Multi-Function Audio Device
> +
> +maintainers:
> +  - Niranjan H Y <niranjan.hy@xxxxxx>
> +
> +description: |
> +  TAC5x1x family of low-power, high-performance audio codecs with integrated
> +  GPIO controller and diagnostic capabilities.
> +
> +  This is the parent binding. Child nodes are bound by these bindings:
> +  - Pin controller: Documentation/devicetree/bindings/pinctrl/ti,tac5x1x-pinctrl.yaml
> +  - Audio codec: Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml
> +
> +  Hardware features:
> +  - Audio ADC/DAC with configurable impedance and voltage references
> +  - 4-pin GPIO controller with alternate functions (PDM, IRQ)
> +  - Analog voltage and current monitoring circuits
> +  - Diagnostic fault detection with interrupt generation
> +
> +  Device datasheets can be found at:
> +    TAA5212:    https://www.ti.com/lit/ds/symlink/taa5212.pdf
> +    TAA5412-Q1: https://www.ti.com/lit/ds/symlink/taa5412-q1.pdf
> +    TAC5111:    https://www.ti.com/lit/ds/symlink/tac5111.pdf
> +    TAC5112:    https://www.ti.com/lit/ds/symlink/tac5112.pdf
> +    TAC5211:    https://www.ti.com/lit/ds/symlink/tac5211.pdf
> +    TAC5212:    https://www.ti.com/lit/ds/symlink/tac5212.pdf
> +    TAC5301:    https://www.ti.com/lit/ds/symlink/tac5301-q1.pdf
> +    TAC5311-Q1: https://www.ti.com/lit/ds/symlink/tac5311-q1.pdf
> +    TAC5312-Q1: https://www.ti.com/lit/ds/symlink/tac5312-q1.pdf
> +    TAC5411-Q1: https://www.ti.com/lit/ds/symlink/tac5411-q1.pdf
> +    TAC5412-Q1: https://www.ti.com/lit/ds/symlink/tac5412-q1.pdf
> +    TAD5112:    https://www.ti.com/lit/ds/symlink/tad5112.pdf
> +    TAD5212:    https://www.ti.com/lit/ds/symlink/tad5212.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,taa5212
> +      - ti,taa5412
> +      - ti,tac5111
> +      - ti,tac5112
> +      - ti,tac5211
> +      - ti,tac5212
> +      - ti,tac5301
> +      - ti,tac5311
> +      - ti,tac5312
> +      - ti,tac5411
> +      - ti,tac5412
> +      - ti,tad5112
> +      - ti,tad5212
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C slave address
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Hardware reset control pin (active low)
> +
> +  interrupts:
> +    maxItems: 1
> +    description: |
> +      Interrupt from device diagnostic circuits to host processor.
> +      Generated on voltage/current fault conditions and other diagnostic events.
> +
> +  clocks:
> +    maxItems: 1
> +    description: Master clock input (MCLK)
> +
> +  clock-names:
> +    items:
> +      - const: mclk
> +
> +  avdd-supply:
> +    description: |
> +      Analog supply voltage input (AVDD pin).
> +      Typical voltages: 1.8V, 3.0V, 3.3V, 5.0V
> +
> +  iovdd-supply:
> +    description: |
> +      Digital I/O supply voltage input (IOVDD pin).
> +      Typical voltages: 1.8V, 3.3V
> +
> +  ti,vref-voltage:

NAK

This was repeated multiple times, was mentioned in my
talks/presentations, is explicitly documented in kernel docs.

This posting has poor quality. First go via internal review because I do
not believe such code was reviewed earlier.

...


> +    default: [2600, 18000]
> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - iovdd-supply
> +
> +unevaluatedProperties: false

You never tested this binding. You cannot have one without example.

Best regards,
Krzysztof