Re: [PATCH] drm/amdgpu/userq: fix memory leak in MQD creation error paths

From: Markus Elfring

Date: Sat Mar 14 2026 - 16:04:35 EST



> Fix by adding kfree() before each goto free_mqd on VA validation
> failure in the COMPUTE, GFX, and SDMA branches.

How do you think about to benefit any more from application of an attribute
like __free(kfree)?
https://elixir.bootlin.com/linux/v7.0-rc3/source/include/linux/cleanup.h#L157-L161

Regards,
Markus