Re: [PATCH] staging: rtl8723bs: Replace network magic numbers with EtherType macros

[Ethan Tidmore]

On Sat Mar 14, 2026 at 4:04 PM CDT, Marcos Andrade wrote:
> Replace hardcoded magic numbers for network protocols (e.g., 0x0806
> for ARP, 0x888e for EAPOL) with their standard EtherType macro
> equivalents (ETH_P_ARP, ETH_P_PAE) defined in <linux/if_ether.h>.
>
> This change improves code readability and aligns the driver with
> standard Linux networking definitions.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@xxxxxxxxx>
> ---

...

> +#include "linux/delay.h"
> +#include "linux/if_ether.h"

You always include linux api headers with <> not "". Also, header files
should be included in alphabetical order:

>  #include <drv_types.h>
   #include <linux/if_ether.h>

You won't include <linux/delay.h> in your v2 for reasons below.

>  
>  static u8 P802_1H_OUI[P80211_OUI_LEN] = { 0x00, 0x00, 0xf8 };
> @@ -128,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
>  		/* Tx buf allocation may fail sometimes, so sleep and retry. */
>  		res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true);
>  		if (res == _FAIL) {
> -			msleep(10);
> +			usleep_range(10000, 11000);

You didn't mention this in your changelog and is an unrelated change.
Please make this its own separate patch. Also, this should be changed
from msleep(10) to fsleep(10 * USEC_PER_MSEC) as this is the new
standard API.

Thanks,

ET